Register    Login    Forum    Search    FAQ Awesomenauts



Post new topic Reply to topic

Author Message
 Post subject: Trailing non-ASCII characters in username cause corruption
 Post Posted: Tue Dec 05, 2017 9:31 pm 
Offline
User avatar

Joined: Sun Jul 14, 2013 11:33 am
Posts: 95
Using a Steam name with a length greater than 16 bytes (when encoded as UTF-8) will sometimes cause a buffer read overflow if the last character is a non-ASCII character. This results in miscellaneous internal strings being appended to the player name in chat messages and kill announcements. The effect is particularly noticable in replays, where the player's name tag is corrupted with different data every 10 seconds (matching the typical length of replay data blocks).

This issue occurs because names are not delimited by character count, but rather by byte count, causing continuation bytes of multibyte characters that happen to be located on the 16 byte boundary to be replaced with the null byte, which is erroneously skipped by the game's UTF-8 parser.

An example name that can trigger this bug is:

012345678901234รค

The issue can be reproduced on Linux Mint 18 (64-bit).


Top 
 Profile  
 
 Post subject: Re: Trailing non-ASCII characters in username cause corrupti
 Post Posted: Wed Dec 13, 2017 9:55 pm 
Offline
User avatar

Joined: Wed Aug 05, 2015 9:39 pm
Posts: 205
Location: San Diego
They should really just hire you as a developer

_________________
steam

main: :think:
second: :clap:
occasionally also play: :worship: :sleep: :scoop: :GnawShock: :rocco: :thumb:


Top 
 Profile  
 
 Post subject: Re: Trailing non-ASCII characters in username cause corrupti
 Post Posted: Thu Dec 14, 2017 3:24 am 
Offline

Joined: Tue Aug 18, 2015 3:50 am
Posts: 1586
but hes not an artist!

_________________
booty booty booty booty booty booty
my crappy discord: https://discord.gg/TGFpteg


Top 
 Profile  
 
 Post subject: Re: Trailing non-ASCII characters in username cause corrupti
 Post Posted: Thu Dec 14, 2017 7:45 pm 
Offline

Joined: Fri Nov 01, 2013 5:07 am
Posts: 1356
i wonder how many talented people don't make the dev team just because they don't speak whatever language it was ronimo needs them to


Top 
 Profile  
 
Display posts from previous:  Sort by  
 
Post new topic Reply to topic